feat(fontlock): fontify the variable and type in typeguard #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Without delving too deep into the code, it looks like a useful improvement. Would you be able to add tests for it, so once committed, we know it will keep working? 🙂 |
Contributor
Author
|
Now looking at this, maybe the This is from VS Code where the
|
Contributor
Author
|
I will add tests, no problem. |
Fuco1
force-pushed
the
feature/fontify-type-guard
branch
from
24e6a81 to
f97b832
Compare
Member
|
Sounds great. Fontifying “is” makes perfectly sense to me. |
Fuco1
force-pushed
the
feature/fontify-type-guard
branch
from
f97b832 to
333a7c5
Compare
Contributor
Author
|
You have really neat testing setup for font-locking. I'm loving the macros :) btw final version looks like this (also with the other PR applied to fontify the argument)
|
josteink
approved these changes
Jul 3, 2022
Member
|
Looks great. Thanks for this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fontify the variable and type in a type guard.
Before
After